docs: update README to reflect supported maintenance version#104
Merged
jackwotherspoon merged 4 commits intogoogleapis:mainfrom Dec 20, 2024
Merged
docs: update README to reflect supported maintenance version#104jackwotherspoon merged 4 commits intogoogleapis:mainfrom
jackwotherspoon merged 4 commits intogoogleapis:mainfrom
Conversation
MySQL vector syntax has changed in the latest maintenance version (see https://cloud.google.com/sql/docs/mysql/work-with-vectors). We are yet to update the integration to use this new syntax, so need to call out the supported versions while we work on a new version of the integration.
product-auto-label
bot
added
the
api: cloudsql-mysql
Contributor
|
/gcbrun |
jackwotherspoon
changed the title
Contributor
|
@juliaofferman do you mind adding to the PR description some details highlighting what the syntax changes are? |
averikitsch
approved these changes
Dec 19, 2024
Collaborator
averikitsch
left a comment
averikitsch
left a comment
There was a problem hiding this comment.
Approving, but can you also add this to the README and https://github.com/googleapis/langchain-google-cloud-sql-mysql-python/blob/main/docs/vector_store.ipynb? Thanks!
Collaborator
|
/gcbrun |
jackwotherspoon
approved these changes
Dec 19, 2024
Contributor
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
LGTM, ditto Averi's comment of adding a note to README.
Also see my other comment about updating description to give more details into what the differences in syntax are now.
Add note that maintenance versions between MYSQL_8_0_36.R20240401.03_00 and MYSQL_8_0_36.R20241208.01_00 are required to the overall README and vector_store notebook.
Contributor
|
/gcbrun |
Underline was shorter than the section heading, causing "sphinx.errors.SphinxWarning: /home/runner/work/langchain-google-cloud-sql-mysql-python/langchain-google-cloud-sql-mysql-python/docs/README.rst:35:Title underline too short.". Fixed the underline to match text
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
juliaofferman
added a commit
to juliaofferman/genai-databases-retrieval-app-mysql
that referenced
this pull request
Feb 27, 2025
Updated integration with this: googleapis/langchain-google-cloud-sql-mysql-python#104 but have not yet updated the sample app.
Yuan325
added a commit
to GoogleCloudPlatform/cymbal-air-toolbox-demo
that referenced
this pull request
Feb 28, 2025
…ported maintenance versions (#529) Updated integration with this: googleapis/langchain-google-cloud-sql-mysql-python#104 but have not yet updated the sample app. --------- Co-authored-by: Yuan <45984206+Yuan325@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL vector syntax has changed in the latest maintenance version (see https://cloud.google.com/sql/docs/mysql/work-with-vectors). We are yet to update the integration to use this new syntax, so need to call out the supported versions while we work on a new version of the integration. The updated syntax includes changing the ANN search function name, parameters, and where it can appear in a query. Additionally, create/drop/alter vector index syntax has changed. There are also some new restrictions, ie a table must have 1000 rows before creating an index.